[PATCH] D72022: [mlir][Linalg] Extend generic ops to allow tensors

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 8 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransforms.h:83
+LogicalResult vectorizeGenericLinalgOpPrecondition(Operation *op);
+SmallVector<Value, 0> vectorizeGenericLinalgOp(PatternRewriter &rewriter,
+                                               Operation *op);
----------------
nicolasvasilache wrote:
> rriddle wrote:
> > Why SmallVector<..., 0>?
> This needs a type compatible with `SmallVector<Value, x>` to be used as a NativeCall with for an op with Variadic returns.
> Do you have a better suggestion?
tentatively marking "Done", will update if a better suggestion is given.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72022/new/

https://reviews.llvm.org/D72022