[PATCH] D71164: [InstCombine] Fix infinite loop due to bitcast <-> phi transforms

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see inline for test nit.



================
Comment at: llvm/test/Transforms/InstCombine/pr44245.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -instcombine -S -o - %s | FileCheck %s
+
----------------
The standard RUN line uses:

```
; RUN: opt -S -instcombine < %s | FileCheck %s
```

I don't know if the extra "-o -" makes any difference, but we prefer the redirect of the input file because it can prevent unintended matching of strings from a file path that managed to escape into the checked output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71164/new/

https://reviews.llvm.org/D71164