[PATCH] D68851: [Utils] Allow update_test_checks to scrub attribute annotations

Tue Dec 31 00:25:35 PST 2019

jdoerfert added a comment.

In D68851#1799748 <https://reviews.llvm.org/D68851#1799748>, @arichardson wrote:

> Could you also make this change to update_cc_test_checks.py?
>
> This code could move to common and we add a `generates_ir` flag to `common.parse_commandline_args(parser)`. If that flag is set, parse_commandline_args adds the `--function-signature` and `--scrub-attributes` command line option and performs the `SCRUB_TRAILING_WHITESPACE_TEST_RE  -> SCRUB_TRAILING_WHITESPACE_AND_ATTRIBUTES_RE` subsitituion?
>  If it's in common there should be no need for a separate update_cc_test_checks test (however, it probably makes sense to wait until D71565 <https://reviews.llvm.org/D71565> has landed to avoid regresssions).

I'm in favor of this happening and I can put it on my list. Though, if you want me to do this it will take some time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68851/new/

https://reviews.llvm.org/D68851