[PATCH] D72017: [Attributor] AANoRecurse check all call sites for `norecurse`

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1935
+      if (AllCallSitesKnown)
+        indicateOptimisticFixpoint();
+      return ChangeStatus::UNCHANGED;
----------------
uenoku wrote:
> jdoerfert wrote:
> > uenoku wrote:
> > > Don't we need to return?
> > We return in the next line either way. If the `checkForAllCallSites` returned true we can *at least* assume `noreturn`. Or did I misunderstand your question?
> I mean we need to return `ChangeStatus::CHANGED` here, isn't it?
The assumed state didn't change so I returned UNCHANGED. This is what `indicateOptimisticFixpoint` returns as well. So far I used the changestatus (only) for the assumed not the known state. I'm not convinced it is useful to indicate "changes" in the known state alone, though I'm open to arguments here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72017/new/

https://reviews.llvm.org/D72017