[PATCH] D72017: [Attributor] AANoRecurse check all call sites for `norecurse`

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 30 23:49:33 PST 2019


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1935
+      if (AllCallSitesKnown)
+        indicateOptimisticFixpoint();
+      return ChangeStatus::UNCHANGED;
----------------
uenoku wrote:
> Don't we need to return?
We return in the next line either way. If the `checkForAllCallSites` returned true we can *at least* assume `noreturn`. Or did I misunderstand your question?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72017/new/

https://reviews.llvm.org/D72017





More information about the llvm-commits mailing list