[PATCH] D71897: [X86] Adding fp128 support for strict fcmp

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D71897#1799607 <https://reviews.llvm.org/D71897#1799607>, @pengfei wrote:

> After a deeper investigation, I agreed with Craig that we should "expand the unsupported calls into multiple compares and control flow in IR". But I think we don't need libcalls. We can get sNaN, qNaN and compare results according to control flow and IRs. We only need to define a target dependent interface `TLI.raiseFPException` to handle exception respectively.


Having a raiseFPException code would make the exception generating code be inlined everywhere. And for X86 it requires generating an exception into both the SSE and X87 domain. That doesn't seem good for code size. We should push on the libraries to do the right thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71897/new/

https://reviews.llvm.org/D71897