[llvm] 991f7ab - [NFC] Add comments in unit test aix-xcoff-toc.ll to clarify the intent
via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 30 19:34:09 PST 2019
Author: jasonliu
Date: 2019-12-31T03:29:50Z
New Revision: 991f7abdfc55ed968ee5593fb3a2d4843498da41
URL: https://github.com/llvm/llvm-project/commit/991f7abdfc55ed968ee5593fb3a2d4843498da41
DIFF: https://github.com/llvm/llvm-project/commit/991f7abdfc55ed968ee5593fb3a2d4843498da41.diff
LOG: [NFC] Add comments in unit test aix-xcoff-toc.ll to clarify the intent
Address David's post review comment in https://reviews.llvm.org/D71667.
Add comments to clarify what we are testing in that file.
Added:
Modified:
llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll
Removed:
################################################################################
diff --git a/llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll b/llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll
index 0ecf68c7e2b0..543cca720293 100644
--- a/llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll
+++ b/llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll
@@ -1,3 +1,5 @@
+; This file tests TOC entry generation and undefined symbol generation.
+
; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc-ibm-aix-xcoff < %s | FileCheck --check-prefixes CHECK,CHECK32 %s
; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc64-ibm-aix-xcoff < %s 2>&1 | FileCheck --check-prefixes CHECK,CHECK64 %s
@@ -42,6 +44,8 @@ define void @foobar() {
ret void
}
+; Test tc entry assembly generation.
+
; CHECK-NOT: .comm a
; CHECK-NOT: .lcomm a
; CHECK-NOT: .comm b
@@ -69,6 +73,9 @@ define void @foobar() {
; CHECK-NEXT: LC7:
; CHECK-NEXT: .tc foobar[TC],foobar[DS]
+
+; Test undefined symbol generation.
+
; SYM: File: {{.*}}aix-xcoff-toc.ll.tmp.o
; SYM: Symbol {{[{][[:space:]] *}}Index: [[#UNDEF_INDX:]]{{[[:space:]] *}}Name: a
; SYM-NEXT: Value (RelocatableAddress): 0x0
@@ -148,6 +155,9 @@ define void @foobar() {
; SYM-NEXT: StabSectNum: 0x0
; SYM-NEXT: }
; SYM-NEXT: }
+
+; Test TOC entry symbol generation.
+
; SYM: Symbol {{[{][[:space:]] *}}Index: [[#TOC_INDX:]]{{[[:space:]] *}}Name: TOC
; SYM-NEXT: Value (RelocatableAddress): 0xA8
; SYM-NEXT: Section: .data
More information about the llvm-commits
mailing list