[PATCH] D71957: [llvm-size] print a blank line between archieve members when using sysv format

Mon Dec 30 19:09:08 PST 2019

TH3CHARLie marked an inline comment as done.
TH3CHARLie added a comment.

In D71957#1799537 <https://reviews.llvm.org/D71957#1799537>, @Jim wrote:

> LGTM.
>  But I have tried gnu size, and I found that has two blank lines between archive members.
>  Here only one blank line.
>  What's your opinion?

If strictly following to the issue's(recall from https://bugs.llvm.org/show_bug.cgi?id=42967) description, adding one blank line would be enough. But indeed this looks inconsistent with GNU's size in sysv format:

1. GNU's size print two blank lines between archive members, this PR prints one
2. At end of the file, GNU's size prints no newline(but since last archive member prints two blank lines), llvm-size prints an additional newline at end of file(see line 843-845).

Thus, I think it is better to adjust this PR so llvm-size's behavior is identical with GNU's

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71957/new/

https://reviews.llvm.org/D71957