[PATCH] D72011: [sanitizers][windows] Global/LocalAlloc interception and tests

Matthew G McGovern via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 30 12:52:04 PST 2019


mcgov planned changes to this revision.
mcgov marked an inline comment as done.
mcgov added a comment.

Planning to rebase this patch on master instead of release/9.x



================
Comment at: compiler-rt/lib/asan/asan_malloc_win.cc:22
 #include "interception/interception.h"
-#include <stddef.h>
 
----------------
mstorsjo wrote:
> Removing `<stddef.h>` here breaks building with mingw, as it's necessary for the `size_t` type.
> 
> If I readd it here, it builds fine for me, but I presume it's removed for a reason?
> 
> 
> FWIW, do note that this file is named `.cpp` in the latest git master; it looks like this diff has been made against an older tree?
> 
> Also, it's useful if the uploaded diffs are made with extra context (`diff -U999`)
Ah yes this was against release/9.x but I will recreate it against master.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72011/new/

https://reviews.llvm.org/D72011





More information about the llvm-commits mailing list