[PATCH] D71841: [FPEnv] Default NoFPExcept SDNodeFlag to false
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 30 11:30:52 PST 2019
uweigand marked 2 inline comments as done.
uweigand added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:3462
+ // Remember whether NodeToMatch could raise an FP exception.
+ bool MayRaiseFPException = mayRaiseFPException(NodeToMatch) &&
+ !NodeToMatch->getFlags().hasNoFPExcept();
----------------
craig.topper wrote:
> Why is only NodeToMatch important? Couldn't we be pattern matching multiple strict nodes?
Good point. I've changed the code to check whether any of the matched nodes may raise an exception.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71841/new/
https://reviews.llvm.org/D71841
More information about the llvm-commits
mailing list