[PATCH] D71944: Support powerpc and sparc when building without init_array.

Mon Dec 30 08:22:54 PST 2019

saugustine added a comment.

In D71944#1798505 <https://reviews.llvm.org/D71944#1798505>, @vvereschaka wrote:

> Would you update the patch and avoid displaying of those error messages for other platforms?

https://reviews.llvm.org/D72005 adds support for aarch64. However, updating this so that no error message is reported seems wrong to me.

Before this patch, those files as they had been compiled are buggy. Using them results in subtly broken binaries, and figuring out what is wrong is quite challenging (ask me how I know!). I suspect your target had been building them, and then ignoring the result. But producing a broken file and hoping that the target doesn't use it seems like a bad idea.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71944/new/

https://reviews.llvm.org/D71944