[PATCH] D71957: [llvm-size] print a blank line between archieve members when using sysv format

[Xuanda Yang via Phabricator via llvm-commits]

TH3CHARLie updated this revision to Diff 235566.
TH3CHARLie added a comment.

revert to origin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71957/new/

https://reviews.llvm.org/D71957

Files:
  llvm/test/tools/llvm-size/archive.test
  llvm/test/tools/llvm-size/multiple-inputs.test
  llvm/test/tools/llvm-size/radix.test
  llvm/tools/llvm-size/llvm-size.cpp


Index: llvm/tools/llvm-size/llvm-size.cpp
===================================================================
--- llvm/tools/llvm-size/llvm-size.cpp
+++ llvm/tools/llvm-size/llvm-size.cpp
@@ -446,7 +446,8 @@
     fmt << "%-" << max_name_len << "s "
         << "%#" << max_size_len << radix_fmt << "\n";
     outs() << format(fmt.str().c_str(), static_cast<const char *>("Total"),
-                     total);
+                     total)
+           << "\n";
   } else {
     // The Berkeley format does not display individual section sizes. It
     // displays the cumulative size for each section type.
Index: llvm/test/tools/llvm-size/radix.test
===================================================================
--- llvm/test/tools/llvm-size/radix.test
+++ llvm/test/tools/llvm-size/radix.test
@@ -49,6 +49,7 @@
 # OCT-SYSV-NEXT: .bss          04     01
 # OCT-SYSV-NEXT: Total         07
 # OCT-SYSV-EMPTY:
+# OCT-SYSV-EMPTY:
 # OCT-SYSV-NEXT: [[FILE2]]  :
 # OCT-SYSV-NEXT: section     size   addr
 # OCT-SYSV-NEXT: .blob        010    040
@@ -69,6 +70,7 @@
 # DEC-SYSV-NEXT: .bss           4      1
 # DEC-SYSV-NEXT: Total          7
 # DEC-SYSV-EMPTY:
+# DEC-SYSV-EMPTY:
 # DEC-SYSV-NEXT: [[FILE2]]  :
 # DEC-SYSV-NEXT: section     size   addr
 # DEC-SYSV-NEXT: .blob          8     32
@@ -89,6 +91,7 @@
 # HEX-SYSV-NEXT: .bss         0x4    0x1
 # HEX-SYSV-NEXT: Total        0x7
 # HEX-SYSV-EMPTY:
+# HEX-SYSV-EMPTY:
 # HEX-SYSV-NEXT: [[FILE2]]  :
 # HEX-SYSV-NEXT: section     size   addr
 # HEX-SYSV-NEXT: .blob        0x8   0x20
Index: llvm/test/tools/llvm-size/multiple-inputs.test
===================================================================
--- llvm/test/tools/llvm-size/multiple-inputs.test
+++ llvm/test/tools/llvm-size/multiple-inputs.test
@@ -17,6 +17,7 @@
 # SYSV-NEXT: .bss           4      1
 # SYSV-NEXT: Total          7
 # SYSV-EMPTY:
+# SYSV-EMPTY:
 # SYSV-NEXT: [[FILE2]]  :
 # SYSV-NEXT: section     size   addr
 # SYSV-NEXT: .text          8     32
Index: llvm/test/tools/llvm-size/archive.test
===================================================================
--- llvm/test/tools/llvm-size/archive.test
+++ llvm/test/tools/llvm-size/archive.test
@@ -48,6 +48,7 @@
 # SYSV-3-NEXT: .bss           4      1
 # SYSV-3-NEXT: Total          7
 # SYSV-3-EMPTY:
+# SYSV-3-EMPTY:
 # SYSV-3-NEXT: archive.test.tmp1   (ex [[ARCHIVE2]]):
 # SYSV-3-NEXT: section     size   addr
 # SYSV-3-NEXT: .text          1      4
@@ -55,6 +56,7 @@
 # SYSV-3-NEXT: .bss           4      1
 # SYSV-3-NEXT: Total          7
 # SYSV-3-EMPTY:
+# SYSV-3-EMPTY:
 # SYSV-3-NEXT: [[FILE2]]  :
 # SYSV-3-NEXT: section     size   addr
 # SYSV-3-NEXT: .text          8      32
@@ -69,6 +71,7 @@
 # SYSV-1-NEXT: .data          2      2
 # SYSV-1-NEXT: .bss           4      1
 # SYSV-1-NEXT: Total          7
+# SYSV-1-EMPTY:
 
 # SYSV-2-NEXT: archive.test.tmp2   (ex [[ARCHIVE]]):
 # SYSV-2-NEXT: section     size   addr


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71957.235566.patch
Type: text/x-patch
Size: 2928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191230/cf7d7702/attachment.bin>