[PATCH] D71885: [PowerPC] replace rlwinm operand 1 with src rlwinm operand 1

[qshanz via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:894
         uint32_t NewMB, NewME;
+        // If FoldingReg has only one use and it it not RLWINMo and
+        // RLWINM8o, safe to delete its def SrcMI. Otherwise keep it.
----------------
it **is** not
s/and/or
it is safe


================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:896
+        // RLWINM8o, safe to delete its def SrcMI. Otherwise keep it.
+        bool CanSrcBeDeleted = MRI->hasOneNonDBGUse(FoldingReg) &&
+                               (SrcMI->getOpcode() == PPC::RLWINM ||
----------------
You don't need to check it here. Please move to line 964 and remove it if its use is 0.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71885/new/

https://reviews.llvm.org/D71885