[PATCH] D71861: [LegalizeVectorOps] Pass the post-UpdateNodeOperands version of the Node to the LowerOperation/PromoteNode/ExpandNode calls

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:270
         Changed = true;
         return ExpandLoad(Op);
       }
----------------
Same issue here?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:295
         Changed = true;
         return ExpandStore(Op);
       }
----------------
Same issue here?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:475
     LLVM_DEBUG(dbgs() << "Trying custom legalization\n");
-    if (SDValue Tmp1 = TLI.LowerOperation(Op, DAG)) {
+    if (SDValue Tmp1 = TLI.LowerOperation(Result, DAG)) {
       LLVM_DEBUG(dbgs() << "Successfully custom legalized node\n");
----------------
Looks like we got this right in the other calls to LowerOperation, just not this one.  Odd.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71861/new/

https://reviews.llvm.org/D71861