[PATCH] D57779: [SLP] Add support for throttling.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 29 16:11:00 PST 2019


dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:1642
+      return llvm::count_if(UseTreeIndices, [this](TreeEntry *Next) {
+               return (Next->Idx != Idx && Next->State == TreeEntry::Vectorize);
+             }) > 1;
----------------
ABataev wrote:
> Check for a cyclic dependency? What we have something like A->B->A?
We don't have to check for cycles here, it is done at 4016. We don't have any paths here, it is done dynamically later. We mark to mark only branch nodes and no problem if the node has cycle like  A->B->A.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779





More information about the llvm-commits mailing list