[PATCH] D71620: [Attributor] AAValueConstantRange: Value range analysis using constant range

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 29 12:23:29 PST 2019


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM. Once we use AAValueSimplify more aggressively in other AAs to get simplified values instead of the ones in the IR, this will be triggered automatically :)



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5189
+    // TODO: `I` is passed to make flow- and context-sensitivity query but it is
+    // not so utilized.
+
----------------
Nit: The second TODO is outdated.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71620/new/

https://reviews.llvm.org/D71620





More information about the llvm-commits mailing list