[PATCH] D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded

Elia Geretto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 29 10:43:22 PST 2019


EliaGeretto updated this revision to Diff 235512.
EliaGeretto added a comment.

I have added comments to explain the reason of some of the changes and added an assert so that, if the `removeGlobalExtension` function is called with an invalid ID, the error will be more noticeable.

Please, let me know if you think the comments are clear enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71959/new/

https://reviews.llvm.org/D71959

Files:
  llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71959.235512.patch
Type: text/x-patch
Size: 5396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191229/548c25c1/attachment.bin>


More information about the llvm-commits mailing list