[PATCH] D71960: [Attributor] AAUndefinedBehavior: AAValueSimplify in memory accessing instructions.
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 28 14:33:49 PST 2019
jdoerfert added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2000
+ // or we got back a simplified value to continue.
+ Optional<Value *> SimplifiedPtrOp = stopOnUndefOrAssumed(A, PtrOp, &I);
+ if (!SimplifiedPtrOp.hasValue())
----------------
Where is `stopOnUndefOrAssumed` defined?
================
Comment at: llvm/test/Transforms/Attributor/IPConstantProp/PR26044.ll:9
+; live value is from %entry. Right now, AAIsDead does not
+; interact with AAUB to know about the dead for.cond1.
define void @fn2(i32* %P) {
----------------
This test is actually really broken. The function can never be executed w/o causing UB. We need to fix these tests to have some behavior.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71960/new/
https://reviews.llvm.org/D71960
More information about the llvm-commits
mailing list