[PATCH] D71711: [COFF] Make the autogenerated .weak.<name>.default symbols static

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Ok, so apparently this doesn't work, as MS link.exe rejects object files, where a IMAGE_SYM_CLASS_WEAK_EXTERNAL symbol points at a symbol which isn't external - so I had to revert it.

Are there any other options then, than trying to do what GCC/binutils does, by changing the suffix `.default` into something that more hopefully is unique? They use the name of another defined (probably non-comdat) external symbol from the same object (that should be unique) as suffix. But that feels like a much larger mess to implement.

FWIW, right now this is blocking me from llvm with clang itself for mingw targets, since we started using an external thread_local variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71711/new/

https://reviews.llvm.org/D71711