[PATCH] D70865: [LV] VPValues for memory operation pointers (NFCI)

[Gil Rapaport via Phabricator via llvm-commits]

gilr marked 13 inline comments as done.
gilr added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2369
   if (Decision == LoopVectorizationCostModel::CM_Interleave)
-    return vectorizeInterleaveGroup(Instr);
+    return vectorizeInterleaveGroup(Instr, State, Addr, BlockInMask);
 
----------------
Ayal wrote:
> Replace with assert? This method should no longer be called to vectorize interleave groups. Unrelated, can be committed separately.
> This method should no longer be called to vectorize interleave groups

Right.

> Unrelated, can be committed separately.

Agreed.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:740
+  getAddr()->printAsOperand(O);
+  VPValue *Mask = getMask();
+  if (Mask) {
----------------
Ayal wrote:
> (This change replacing User->getOperand(0) with getMask(), here and in VPInterleaveGroupRecipe::print() above, belonged to D68577; can commit separately)
Separated into D71964


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70865/new/

https://reviews.llvm.org/D70865