[PATCH] D71851: Use the first location in the fused location for diagnostic handler

[River Riddle via Phabricator via llvm-commits]

rriddle requested changes to this revision.
rriddle added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/test/IR/diagnostic-handler.mlir:5
+func @call_site_loc_in_fused() -> i32 {
+  //CHECK: mysource1: note:
+  //CHECK: mysource2: note: called from
----------------
Add space after // lines.


================
Comment at: mlir/test/lib/Transforms/TestDiagnosticHandler.cpp:1
+//===- TestDiagnosticHandler.cpp - Pass to test diagnostic handler --------===//
+//
----------------
Do we actually need an entirely new test driver? Seems like this could just be tested with a verifier error where the parsed operation has a callsite location.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71851/new/

https://reviews.llvm.org/D71851