[PATCH] D71930: [mlir][spirv] Add basic definitions for supporting availability

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 4 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp:1
 //===- SPIRVSerializationGen.cpp - SPIR-V serialization utility generator -===//
 //
----------------
mravishankar wrote:
> antiagainst wrote:
> > mravishankar wrote:
> > > Is there a reason to not have them in a separate file. The additions are completely independent here right?
> > Wanted to keep all SPIR-V specific TableGen backend in one place. I think this is okay for now. 
> Ok, wont try to push it. Wouldn't most of these methods to go into TblGen core infra?
Yup before that they will stay scoped to the SPIR-V dialect. We already have a few SPIR-V specific TableGen backends; there is no clear cut rule as which to put in which file, if we have multiple source files for SPIR-V; so rather to put all of them in one file until it becomes too large to tolerate. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71930/new/

https://reviews.llvm.org/D71930