[PATCH] D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet.

Fri Dec 27 11:30:15 PST 2019

dblaikie added inline comments.

================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-debug-aranges-error-cases.s:71-72
+.ifdef CASE4
+## Length overrun for the DWARF64 case.
+# CHECK4: address range table at offset 0x0 has invalid length
+.Llen:
----------------
Not sure if this needs its own test case - since it's the same error/code path for both 32 and 64 bit lengths. (& having only one test for length overrun would enable all the tests to be done in one object file/run, rather than separate RUN lines for each one (some systems, like Windows, have significant per-process overhead so it's nice to keep the total number of separate command invocations down if practical/convenient))

================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-debug-aranges.s:84
+# CHECK-SAME: seg_size = 0x00
+    .space  7 - (. - .L4 + 7) % 8   # Padding
+.L4tuples:
----------------
Similar feedback given on other cases - this is probably overcomplicated (given it already has the magic number 7 and 8 - so maybe hardcoding the exact value, rather than this formula, would be simpler - and include a comment about what this achieves)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71876/new/

https://reviews.llvm.org/D71876