[PATCH] D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract().
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 27 11:21:06 PST 2019
dblaikie added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugArangeSet.cpp:60-63
+ return createStringError(errc::invalid_argument,
+ "address range table at offset 0x%" PRIx64
+ " has invalid length",
+ Offset);
----------------
Could this be phrased more specifically - "length exceeds section size" or something like that?
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugArangeSet.cpp:64-68
+ if (HeaderData.AddrSize != 4 && HeaderData.AddrSize != 8)
+ return createStringError(errc::invalid_argument,
+ "address range table at offset 0x%" PRIx64
+ " has invalid address size",
+ Offset);
----------------
Could this be more specific about what's invalid about the address size ("unsupported address size: 5 (4 and 8 supported)" or the like?)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71875/new/
https://reviews.llvm.org/D71875
More information about the llvm-commits
mailing list