[PATCH] D71931: [DWARF] Allow empty address range tables.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 27 11:02:42 PST 2019
dblaikie added inline comments.
================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-debug-aranges.s:21
+# CHECK-SAME: seg_size = 0x00
+ .space 7 - (. - .L1 + 7) % 8 # Padding
+.L1tuples:
----------------
Might be better to hardcode the value here (since you're hardcoding the '7' anyway) & include a comment about what this is padding out to?
(& just for amusement I looked at the DWARF spec & I find no mention of this padding - though clearly GCC and LLVM emit & parse/expect such padding)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71931/new/
https://reviews.llvm.org/D71931
More information about the llvm-commits
mailing list