[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

Fri Dec 27 09:47:12 PST 2019

modocache marked an inline comment as done.
modocache added inline comments.

================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227
+          MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass()));
+          MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePass()));
+          MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass()));
----------------
junparser wrote:
> Since coro elision depends on other optimization pass(inline and so on)  implicitly,  how can we adjust the pipeline to achieve this.
One option would be to use the new pass manager's registration callbacks, like `PassBuilder::registerPipelineStartEPCallback` or `PassBuilder::registerOptimizerLastEPCallback`. These work similarly to the old pass manager's `PassManagerBuilder::addExtension`. That's something that I think would be good to improve in a follow-up patch, but let me know if you'd rather see it in this one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71903/new/

https://reviews.llvm.org/D71903