[PATCH] D71912: [mlir] Floating constants for import-llvm

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added a comment.

Thanks!
I would also add an error message in cases where constant conversion failed and made sure the callers of getConstantAsAttr are aware that it can return null (there may be x86_fp80 and fp128 values, that are not supported in MLIR at all). Fine for a separate commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71912/new/

https://reviews.llvm.org/D71912