[PATCH] D70927: Introduce a CallGraph updater helper class

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:456
           Edge *E = N->lookup(CalleeN);
-          // FIXME: We should really handle adding new calls. While it will
-          // make downstream usage more complex, there is no fundamental
----------------
This patch seems to be doing two things. One, is fixing this FIXME, and the second is adding the CallGraphUpdater wrapper. Can you split out these two changes?

Also, can you add unit tests for these various things?



================
Comment at: llvm/lib/Transforms/Utils/CallGraphUpdater.cpp:45
+  } else if (LCG) {
+    // TODO
+  }
----------------
What's the state of this? Should we have an assert for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70927/new/

https://reviews.llvm.org/D70927