[PATCH] D71565: Make mangled_names.test and update_cc_test_checks.py work with Python 2.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 26 22:24:16 PST 2019
MaskRay added a subscriber: rnk.
MaskRay added a comment.
In D71565#1797014 <https://reviews.llvm.org/D71565#1797014>, @thakis wrote:
> Looks like it's exactly 10, out of 140, none of them covered by tests.
>
> Since I debugged this failure, I'll go ahead and land this change.
>
> If someone wants to do the work and pull the py3 detection out of this lit.local.cfg into an higher-level lit place and use that, that's fine with me. But I think per thread there's consensus that we shouldn't have this kind of logic on a per-tool level.
@rnk partially reverted a previous `update_*_checks.py` change in 287307a0c60b68099d5f9dd22ac1db2a42593533 <https://reviews.llvm.org/rG287307a0c60b68099d5f9dd22ac1db2a42593533>.
(FWIW, I still think changing shebang from `python3` back to `python` does not worth the trouble.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71565/new/
https://reviews.llvm.org/D71565
More information about the llvm-commits
mailing list