[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:484
+    LPM2.addPass(LoopFullUnrollPass(Level,
+                                    /*OnlyWhenForced=*/!PTO.LoopUnrolling,
                                     PTO.ForgetAllSCEVInLoopUnroll));
----------------
I would document that the normal unroll pass does not honor the forced unroll, it is surprising to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71687/new/

https://reviews.llvm.org/D71687