[PATCH] D71780: [msan] Check qsort input.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc:9673
+    COMMON_INTERCEPTOR_UNPOISON_PARAM(2);
+    (i % 2) ? compar(p, q) : compar(q, p);
+  }
----------------
vitalybuka wrote:
> maybe just:
> ```
> compar(p, q);
> compar(q, p);
> ```
A sensible comparator should do the same work no matter what the order of arguments is. Just compar(p, q) should suffice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71780/new/

https://reviews.llvm.org/D71780