[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis updated this revision to Diff 235364.
baziotis added a comment.

- Added one test to check propagation of null - it's not behaving as we'd like.
- Abstracted the `AAValueSimplify` usage in `AAUndefinedBehavior`.

A couple of notes:

- Now the same cases as before fail plus a couple more. But, the 3 cases that were failing before were crashing. Now they just give different result

which is expected. It probably is easy to change them.
The other cases however crash but because the number of iterations is not the specified. I may not be the most appropriate person to look into that.

- I still don't understand why `getPointerOperand()` returns `null` on `volatile` instructions (although I have guess it is to prevent further processing). Is it correct what I do?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71799/new/

https://reviews.llvm.org/D71799

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/test/Transforms/Attributor/undefined_behavior.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71799.235364.patch
Type: text/x-patch
Size: 15050 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191226/6cf8fadc/attachment.bin>