[PATCH] D71055: [LV][NFC] Some refactoring and renaming to facilitate next change.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

This looks good to me, with a couple of final optional comments.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2685
 void InnerLoopVectorizer::emitMinimumIterationCountCheck(Loop *L,
                                                          BasicBlock *Bypass) {
   Value *Count = getOrCreateTripCount(L);
----------------
Should the "local" `Bypass` also be removed/replaced, in this and following emit*() methods?

(May have been better if these emit*() methods originally returned the new preheader they create, so their callers would do LoopVectorPreHeader = emit*(Lp, LoopVectorPreHeader), emphasizing the chaining.)


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2958
+  assert(LoopVectorPreHeader && "Invalid loop structure");
+  assert(LoopExitBlock && "Must have an exit block");
+
----------------
The above 5 lines could remain in their original place; they're not part of splitting the single block loop etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71055/new/

https://reviews.llvm.org/D71055