[PATCH] D71899: [Coroutines][2/6] New pass manager: coro-split
Brian Gesiak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 26 09:38:27 PST 2019
modocache added a comment.
> Also consider using the child/parent revision feature to ease the navigation between dependent patches.
Oh, thanks! I hadn't realized LLVM's Phabricator instance had this feature. I just edited the parent/child revisions as per your suggestion, they're now displayed as a stack.
> Changes like the addition of `const` or renaming of the pass to be `Legacy` could be done in NFC commits prior to this one without pre-commit review (IMHO)
Good point! I considered doing so with `const`, but renaming the passes to `Legacy` sounds good, too. I'll split out these changes and commit them without review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71899/new/
https://reviews.llvm.org/D71899
More information about the llvm-commits
mailing list