[PATCH] D71904: [mlir] GPU: introduce utilities for promotion to workgroup memory

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/GPU/GPUOps.td:122
+    /// shape and element type.
+    Value *addWorkgroupAttribution(ArrayRef<int64_t> shape, Type elementType);
+
----------------
BTW: Value is now value-typed.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp:183
+  assert(fromType.getRank() != 0);
+  assert(std::distance(region.begin(), region.end()) == 1 &&
+         "unstructured control flow not supported");
----------------
has_single_element


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71904/new/

https://reviews.llvm.org/D71904