[PATCH] D71888: [mlir] Added llvm.resume in LLVM IR Dialect

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.
Herald added a subscriber: jpienaar.


================
Comment at: mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp:761
+
+static void printResumeOp(OpAsmPrinter &p, ResumeOp &op) {
+  assert(op.getNumOperands() == 1);
----------------
> ResumeOp &

Operations are value-typed, so you shouldn't pass by reference or pointer in general.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71888/new/

https://reviews.llvm.org/D71888