[PATCH] D71828: [InstCombine] Convert vector store to scalar store if only one element updated

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 26 00:06:14 PST 2019


lkail added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:1196
+    if (!Load->isSimple() ||
+        Load->getPointerOperand() != SI.getPointerOperand())
+      return nullptr;
----------------
Not an expert of `opt`, I just wonder is it more proper to check if `Load->getPointerOperand()` `MustAlias` `SI.getPointerOperand()`, since there might be `bitcast`s of these pointers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71828/new/

https://reviews.llvm.org/D71828





More information about the llvm-commits mailing list