[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

Mon Dec 23 15:10:06 PST 2019

dblaikie added a comment.

In D70696#1795302 <https://reviews.llvm.org/D70696#1795302>, @yonghong-song wrote:

> > Could you link to particular bots that have logs showing they ran this test? (perhaps the logs have been retired by now, though - since this patch was reverted :/ - but then at least seeing which bots run BPF tests would be helpful)
>
> @dblaikie Actually, I do not have direct proof that this test is running on buildbot. I only knew BPF is enabled by a lot of bots. I tried to search through emails when I got from buildbot failures like:
>
>   clang-cmake-x86_64-avx2-linux
>   llvm-clang-win-x-aarch64
>   llvm-clang-win-x-armv7l
>   clang-hexagon-elf
>   clang-with-thin-lto-ubuntu
>   clang-ppc64be-linux-lnt
>   sanitizer-x86_64-linux-bootstrap-msan
>   clang-s390x-linux
>   sanitizer-x86_64-linux-fuzzer
>   ......
>   
>
> The contents of buildbot failures are all gone and not accessible now. Will definitely check buildbot BPF coverage next time when I saw any issues.

Hmm, yeah, I thought some of the buildbots print out verbose test logs, showing every test execution (even the passing ones) , but I guess I'm mistaken.

Probably worth waiting a few days (maybe until after the holidays/new year) to see if @rnk has some more info that'd help debug the issue before committing again.

(or, given it's the holidasy and not many people are around, some "testing on the bots" might be acceptable (though I guess we already know the bots aren't failing... or you'd have got email, etc... so maybe that doesn't add much value?))

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70696/new/

https://reviews.llvm.org/D70696