[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 14:16:36 PST 2019


dblaikie added a comment.

In D70696#1794440 <https://reviews.llvm.org/D70696#1794440>, @rnk wrote:

> Three of these tests have been failing for me locally since this patch landed:
>
>   Failing Tests (3):
>       Clang :: CodeGen/debug-info-extern-basic.c
>       Clang :: CodeGen/debug-info-extern-duplicate.c
>       Clang :: CodeGen/debug-info-extern-multi.c 
>
>
> I suspect bots do not see these failures because the BPF target is experimental. I would recommend that you:
>
> - do not use %clang in CodeGen tests, use %clang_cc1
> - find a way to make the test run without the BPF target
>
>   I'll take a look at fixing forward.


Got any more details on the nature of the failure/repro steps?

In D70696#1794480 <https://reviews.llvm.org/D70696#1794480>, @yonghong-song wrote:

> @rnk I just submitted a patch https://reviews.llvm.org/D71818 to use `%clang_cc1` instead of `%clang` in the test. Could you check whether this fixed your issue or not?
>
> I cannot remove BPF target requirement as only BPF target can trigger debug info generation for extern variables. This is by design as discussed in this patch review due to concerns it may blow up debug info binary size for existing applications. This may be relaxed in the future through some flags. BPF is used on linux platform only.


If needed/useful, we could add a (just a cc1 flag, not a full driver flag) to support expliictly enabling this feature regardless of target, for testing purposes - but I'm not sure that's needed as yet.

> As far as I know, BPF is enabled for a lot of bots, ubuntu, x86, ppc, arm, etc. So the coverage of this feature should be fine.

Could you link to particular bots that have logs showing they ran this test? (perhaps the logs have been retired by now, though - since this patch was reverted :/ - but then at least seeing which bots run BPF tests would be helpful)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70696/new/

https://reviews.llvm.org/D70696





More information about the llvm-commits mailing list