[PATCH] D71829: [PowerPC] Exploit the rlwinm instructions for "and" with constant.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 26 01:54:45 PST 2019


shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.

LGTM with one nit comment.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4461
+
+    // It is not 16-bit imm that means we need two instructions at least if
+    // using "and" instruction. Try to exploit it with rotate mask instructions.
----------------
imm16 should be handle as well in new patch?  comment should update? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71829/new/

https://reviews.llvm.org/D71829





More information about the llvm-commits mailing list