[PATCH] D71833: [PowerPC] if value type is changed after folding rlwinm, stop folding

qshanz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 25 18:14:07 PST 2019


steven.zhang accepted this revision.
steven.zhang added a comment.
This revision is now accepted and ready to land.

LGTM with some minor nit.



================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:924
+                               NewME) && NewMB <= NewME)|| SrcMaskFull) {
+          // Here we only handle MBMI <= MEMI cases, so NewMB must be not bigger
+          // than NewME. Otherwise we get a 64 bit value after folding, but MI
----------------
s/cases/case
s/not/no



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71833/new/

https://reviews.llvm.org/D71833





More information about the llvm-commits mailing list