[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 25 08:37:14 PST 2019
jdoerfert added a comment.
In D71799#1796062 <https://reviews.llvm.org/D71799#1796062>, @baziotis wrote:
> In D71799#1795979 <https://reviews.llvm.org/D71799#1795979>, @uenoku wrote:
>
> > LGTM otherwise
>
>
> Great! Your change on `AAValueSimplify` was committed along with my previous revisions, so let me do an updated diff based on that (and also address the comments).
Assuming I understand you correctly, you should.
> I think it's better to do Johannes' suggestions on a different revision.
Yes.
@uenoku Can you commit this for @baziotis? (https://llvm.org/docs/DeveloperPolicy.html#commit-messages)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71799/new/
https://reviews.llvm.org/D71799
More information about the llvm-commits
mailing list