[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.

Wed Dec 25 07:46:50 PST 2019

baziotis marked an inline comment as done.
baziotis added a comment.

In D71799#1795979 <https://reviews.llvm.org/D71799#1795979>, @uenoku wrote:

> LGTM otherwise

Great! Your change on `AAValueSimplify` was committed along with my previous revisions, so let me do an updated diff based on that (and also address the comments).
I think it's better to do Johannes' suggestions on a different revision.

================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2141
 private:
-  // A set of all the (live) memory accessing instructions
-  // that are _not_ assumed to cause UB.
+  // A set of all the (live) instructions that are known to _not_ cause UB.
   //   Note: The correctness of the procedure depends on the fact that this
----------------
uenoku wrote:
> Could you add a comment here to say that instruction in `NoUBInst` might cause UB?
Of course.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71799/new/

https://reviews.llvm.org/D71799