[PATCH] D71697: [llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup.

[George Rimar via Phabricator via llvm-commits]

grimar marked 3 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbols.test:83
+
+## Case 4: Test that `--symbols` triggers `--dyn-symbols` implicitly for llvm-readelf,
+##         but not for llvm-readobj.
----------------
MaskRay wrote:
> Rather than "trigger ... implicitly", you may say --symbols implies --dyn-symbols for llvm-readelf.
gr8! :)


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbols.test:89
+## Case 5: Test that `--dyn-symbols` does not trigger `--symbols` implicitly.
+# RUN: llvm-readobj --dyn-symbols %t64 | FileCheck %s --implicit-check-not="{{^}}Symbols ["
+# RUN: llvm-readelf --dyn-symbols %t64 | FileCheck %s --implicit-check-not="Symbol table '.symtab'"
----------------
MaskRay wrote:
> `{{^}}` can be deleted.
> 
>  The fact that `DynamicSymbols [` does not follow a `{{^}}` made me wonder why `{{^}}` is not here...
> {{^}} can be deleted.

No. `--dyn-symbols` triggers `DynamicSymbols [`, so I can't remove `{{^}}`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71697/new/

https://reviews.llvm.org/D71697