[llvm] 1ac7c50 - [WinEH] Delete addFnAttr("no-frame-pointer-elim") which seems no longer needed

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 24 17:03:47 PST 2019


Author: Fangrui Song
Date: 2019-12-24T17:02:19-08:00
New Revision: 1ac7c50ded423de9a5101e1646da0287cc83d4cb

URL: https://github.com/llvm/llvm-project/commit/1ac7c50ded423de9a5101e1646da0287cc83d4cb
DIFF: https://github.com/llvm/llvm-project/commit/1ac7c50ded423de9a5101e1646da0287cc83d4cb.diff

LOG: [WinEH] Delete addFnAttr("no-frame-pointer-elim") which seems no longer needed

It was added in rL238619.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D71862

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86WinEHState.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86WinEHState.cpp b/llvm/lib/Target/X86/X86WinEHState.cpp
index 35b721b4c9f3..78d3f6460189 100644
--- a/llvm/lib/Target/X86/X86WinEHState.cpp
+++ b/llvm/lib/Target/X86/X86WinEHState.cpp
@@ -179,11 +179,6 @@ bool WinEHStatePass::runOnFunction(Function &F) {
                       {Int8PtrType, Type::getInt32Ty(TheModule->getContext())},
                       /*isVarArg=*/true));
 
-  // Disable frame pointer elimination in this function.
-  // FIXME: Do the nested handlers need to keep the parent ebp in ebp, or can we
-  // use an arbitrary register?
-  F.addFnAttr("no-frame-pointer-elim", "true");
-
   emitExceptionRegistrationRecord(&F);
 
   // The state numbers calculated here in IR must agree with what we calculate


        


More information about the llvm-commits mailing list