[PATCH] D71832: [TypePromotion] Make TypeSize a class member

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/CodeGen/TypePromotion.cpp:966-967
   for (BasicBlock &BB : F) {
     auto &Insts = BB.getInstList();
     for (auto &I : Insts) {
       if (AllVisited.count(&I))
----------------
rnk wrote:
> Unrelated nit: Why not `for (auto &I : BB)`? The instruction list is a bit of an implementation detail.
I think this was because I was concerned about modifying the block while iterating through it, but now I can't see why it can't be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71832/new/

https://reviews.llvm.org/D71832