[PATCH] D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 13:46:33 PST 2019


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

`std::string ELFFile<ELFT>::getDynamicTagAsString(uint64_t Type) const` is used by `llvm-objdump -p` (private headers). It is indeed almost identical to the `llvm-readelf -d` function.

Regarding the behavior change `(<unknown>)` -> `(<unknown:>0x12345678)`, I agree with you that it probably does not matter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71835/new/

https://reviews.llvm.org/D71835





More information about the llvm-commits mailing list