[PATCH] D71841: [FPEnv] Default NoFPExcept SDNodeFlag to false

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:675
+  bool isTargetStrictFPOpcode() const {
+    return NodeType >= ISD::FIRST_TARGET_STRICTFP_OPCODE;
+  }
----------------
uweigand wrote:
> andrew.w.kaylor wrote:
> > Shouldn't this also check for < FIRST_TARGET_MEMORY_OPCODE?
> As I said above: 
> 
> > (Note that there a bit of a quirk in identifying target nodes that are both memory nodes and strict FP nodes. To simplify the logic, right now all target memory nodes are automatically also considered strict FP nodes -- this could be fixed by adding one more range.)
> 
> Not sure what the best way to handle this is.
Yeah, sorry, I comment before reading the whole description (or apparently the comment here). I'm not sure how much practical impact this will have, but it just feels wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71841/new/

https://reviews.llvm.org/D71841