[PATCH] D71766: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION fields of an ELF header.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-header-abi-version.test:39
+  Machine:    EM_X86_64
+  ABIVersion: 0x34 ## == 52
+
----------------
The comment may be redundant... As 52 and `0x34` appear on adjacent lines above. It should be obvious.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-header-os-abi.test:8
+
+# OSABI-NONE-LLVM: OS/ABI: SystemV (0x0){{$}}
+# OSABI-NONE-GNU:  OS/ABI: UNIX - System V{{$}}
----------------
It looks like `{{$}}` can be avoided by using `FileCheck --match-full-line`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71766/new/

https://reviews.llvm.org/D71766