[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.

Mon Dec 23 09:25:05 PST 2019

baziotis added a comment.

In D71799#1794897 <https://reviews.llvm.org/D71799#1794897>, @uenoku wrote:

> Sorry for confusing you. I have missed that the shortcut was introduced(https://github.com/llvm/llvm-project/commit/2dad729f0c7b8665d362baecd8ff52449b26051d). I agree that `None` and `isKnown()` means `undef`.
>
>   SimplifiedV = ...;
>     if (Simplified. isKnown() && (!SimplifiedV.hasValue() || (SimplifiedV.getValue() == undef))
>       KnownUBInsts.insert;
>   }
>
>
> Finally, I think this will work anyway! I should have suggested this to you first;) Really sorry!

No worries, thanks for your time. :) Yes it will work, I've tested it yesterday but I was just waiting for an affirmation on the aforementioned question.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71799/new/

https://reviews.llvm.org/D71799